transpile: Always use absolute paths when referring to crates #1408

Rua · 2025-10-11T14:33:23Z

Fixes Qualified paths like libc::c_int should be globally qualified like ::libc::c_int to avoid name clashes #447.

kkysen

I think the CI failings are because you didn't update the os- and arch-specific snapshots that aren't run locally.

c2rust-transpile/src/convert_type.rs

kkysen · 2025-10-11T19:15:55Z

c2rust-transpile/tests/snapshots/[email protected]

 )]
 #[no_mangle]
-pub static mut TRUE: core::ffi::c_int = 1 as core::ffi::c_int;
+pub static mut TRUE: ::core::ffi::c_int = 1 as ::core::ffi::c_int;


@ahomescu, is #1399 able to handle stuff like this and still shorten the paths with imports? Also, is it or another refactor able to remove the :: where not needed? Would that be difficult at all?

The change here is correct and handles some edge cases, but it is longer, so it'd be nice to be able to refactor out the unnecessary ones afterward.

Maybe, I can give it a try. I'm not sure you can run reorganize_definitions multiple times on the same code base, but we can find out.

Rua · 2025-10-11T21:18:40Z

I think the CI failings are because you didn't update the os- and arch-specific snapshots that aren't run locally.

The three snapshot CI runs are failing because the leading double colon :: is expected by the snapshot (because I added it) but, for some reason, not actually generated by the transpiler. And this has me rather puzzled at the moment. For the Clang 18 test, snapshots__transpile-x86_64@vm_x86.c.snap gives this diff:

    6     6 │     unused_assignments,
    7     7 │     unused_mut
    8     8 │ )]
    9     9 │ #![feature(asm)]
   10       │-use ::core::arch::asm;
         10 │+use core::arch::asm;
   11    11 │ #[derive(Copy, Clone)]
   12    12 │ #[repr(C)]
   13    13 │ pub struct vm_t {
   14    14 │     pub programStack: ::core::ffi::c_int,

I can find only one place in the whole codebase that adds an import with the string "asm":

c2rust/c2rust-transpile/src/translator/assembly.rs

Line 1062 in 8d87265

item_store.add_use(vec!["core".into(), "arch".into()], "asm");

All items added to the item store are eventually fed through PathedMultiImports::into_items, where I have added lines to make absolute paths:

c2rust/c2rust-transpile/src/rust_ast/item_store.rs

Lines 55 to 64 in 8d87265

    
               if leaves.len() == 1 { 
        
                   path.push(leaves.pop().unwrap()); 
        
                   let path = mk().abs_path(path); 
        
                   attrs.use_simple_item(path, None as Option<Ident>) 
        
               } else { 
        
                   let path = mk().abs_path(path); 
        
                   attrs.use_multiple_item(path, leaves.into_iter()) 
        
               } 
        
           }

And yet, the generated code does not have an absolute path. It's as if abs_path there is having no effect.

kkysen

This is weird. fs::read_to_string(&platform_rs_path).unwrap() is showing the use ::core::arch::asm;, but then the fs::read_to_string(&rs_path).unwrap() a few lines later is showing use core::arch::asm; again.

kkysen · 2025-10-11T22:19:14Z

Ah, I figured out what it is. It's rustfmt. It's deleting the ::.

kkysen

@Rua, I rebased this on #1409 to test if it fixes the issue.

Rua · 2025-10-13T07:30:31Z

It seems to be fixed, but it is now getting stuck on the empty Ident issue fixed by #1411.

@Rua

This is what was breaking #1408 (comment). @Rua, I think this should fix your issue. Let me know and you can review this PR.

kkysen · 2025-10-13T22:50:26Z

Ugh, why did this get closed?

fw-immunant · 2025-10-13T22:51:59Z

Ugh, why did this get closed?

GH seems to suggest it was closed because the target branch was deleted.

kkysen · 2025-10-13T22:53:49Z

Ugh, why did this get closed?

GH seems to suggest it was closed because the target branch was deleted.

Ugh, GitHub being dumb again. Normally when you delete the target branch, it changes it to master (or whatever the target branch of the PR that was closed is), but apparently when it's an external PR, it just closes the PR.

Rua · 2025-10-14T09:57:14Z

Hmm strange, the CI is still failing on the same error. Is it perhaps using an old version?

EDIT: But the MacOS test passed... huh?

kkysen · 2025-10-14T10:19:24Z

Hmm strange, the CI is still failing on the same error. Is it perhaps using an old version?

EDIT: But the MacOS test passed... huh?

I'm not sure, but the error message is slightly different. Might be a different error?

Rua · 2025-10-14T10:44:54Z

Transpile is able to generate a new Cargo.toml when transpiling, and it will fill it with dependencies used by the transpiled code, including c2rust-bitfields. Is it possible that the file it generates there refers to the stable/crates.io version of c2rust-bitfields, and not the one in the current directory tree? If so, that could explain what's going on maybe.

kkysen

Transpile is able to generate a new Cargo.toml when transpiling, and it will fill it with dependencies used by the transpiled code, including c2rust-bitfields. Is it possible that the file it generates there refers to the stable/crates.io version of c2rust-bitfields, and not the one in the current directory tree? If so, that could explain what's going on maybe.

I think you're right. And it seems to be using c2rust-bitfields= "0.3" from what I can tell, which is very old.

kkysen

@Rua, this should be fixed once #1420 merges (and the stack of PRs in front of it as well).

…of c2rust crates are used (#1420) The `transpile.gen.sh`s generated by `c2rust-testsuite` use `C2RUST_DIR` to set dependencies in generated `Cargo.toml`s to point to the current `c2rust` directory, allowing it to test with the current version of `c2rust-bitfields` and `c2rust-asm-casts`. This needs #1419 fixed first, and it should unblock #1408, which depends on the `c2rust-bitfields-derive` fix in #1411.

Rua · 2025-10-23T20:54:30Z

This is now passing the tests, but the Clang 15 test seems to be failing for an unrelated reason.

EDIT: Seems to be fixed again.

Rua force-pushed the abs-crate branch from eee016f to aa99558 Compare October 11, 2025 15:37

kkysen reviewed Oct 11, 2025

View reviewed changes

Rua force-pushed the abs-crate branch 2 times, most recently from 71c6b98 to 8d87265 Compare October 11, 2025 20:30

kkysen reviewed Oct 11, 2025

View reviewed changes

kkysen mentioned this pull request Oct 11, 2025

transpile: tests: specify --edition 2021 for rustfmt, too #1409

Merged

Rua force-pushed the abs-crate branch from db3016d to c535e3a Compare October 12, 2025 10:56

kkysen force-pushed the abs-crate branch from 2b806c0 to 275b675 Compare October 13, 2025 04:35

kkysen changed the base branch from master to kkysen/snapshots-rustfmt-edition October 13, 2025 04:35

kkysen force-pushed the kkysen/snapshots-rustfmt-edition branch from 400a962 to c9a70be Compare October 13, 2025 04:36

kkysen reviewed Oct 13, 2025

View reviewed changes

kkysen added a commit that referenced this pull request Oct 13, 2025

transpile: tests: specify --edition 2021 for rustfmt, too (#1409)

55e1c24

This is what was breaking #1408 (comment). @Rua, I think this should fix your issue. Let me know and you can review this PR.

kkysen deleted the branch immunant:master October 13, 2025 22:47

kkysen closed this Oct 13, 2025

kkysen reopened this Oct 13, 2025

kkysen changed the base branch from kkysen/snapshots-rustfmt-edition to master October 13, 2025 22:52

Rua force-pushed the abs-crate branch 2 times, most recently from 2b806c0 to d41596d Compare October 14, 2025 09:40

kkysen reviewed Oct 19, 2025

View reviewed changes

kkysen mentioned this pull request Oct 19, 2025

ci: set C2RUST_DIR for c2rust-testsuite so that current versions of c2rust crates are used #1420

Merged

kkysen reviewed Oct 23, 2025

View reviewed changes

Rua force-pushed the abs-crate branch 2 times, most recently from d2f9a1e to 9c8e078 Compare October 23, 2025 20:40

Rua added 3 commits October 24, 2025 10:35

transpile: Simplify path_ty expressions

61ae26a

transpile: Always use absolute paths when referring to crates

9506e09

transpile: Support absolute paths in PathedMultiImports

8cb4d97

Rua force-pushed the abs-crate branch from 9c8e078 to 8cb4d97 Compare October 24, 2025 08:36

kkysen approved these changes Oct 24, 2025

View reviewed changes

kkysen merged commit 8254c36 into immunant:master Oct 24, 2025
5 checks passed

kkysen mentioned this pull request Oct 28, 2025

reorganize_definitions: Shorten paths that are imported into the current module #1399

Open

transpile: Always use absolute paths when referring to crates #1408

transpile: Always use absolute paths when referring to crates #1408

Uh oh!

Conversation

Rua commented Oct 11, 2025

Uh oh!

kkysen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kkysen Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

ahomescu Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Rua commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kkysen left a comment

Choose a reason for hiding this comment

Uh oh!

kkysen commented Oct 11, 2025

Uh oh!

kkysen left a comment

Choose a reason for hiding this comment

Uh oh!

Rua commented Oct 13, 2025

Uh oh!

kkysen commented Oct 13, 2025

Uh oh!

fw-immunant commented Oct 13, 2025

Uh oh!

kkysen commented Oct 13, 2025

Uh oh!

Rua commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kkysen commented Oct 14, 2025

Uh oh!

Rua commented Oct 14, 2025

Uh oh!

kkysen left a comment

Choose a reason for hiding this comment

Uh oh!

kkysen left a comment

Choose a reason for hiding this comment

Uh oh!

Rua commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Rua commented Oct 11, 2025 •

edited

Loading

Rua commented Oct 14, 2025 •

edited

Loading

Rua commented Oct 23, 2025 •

edited

Loading